Prod : 프로필이 아닌 유저에서 전화번호를 조회한 정보로 알림톡 전송#323
Conversation
…umber formatting method
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @polyglot-k, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 알림톡 전송을 위한 전화번호 조회 방식을 변경합니다. 기존에는 사용자 프로필 정보에서 전화번호를 가져왔으나, 이제는 사용자 엔티티에서 직접 전화번호를 조회하도록 수정되었습니다. 이는 알림이 사용자의 기본 연락처 정보를 통해 정확하게 전송되도록 보장합니다.
Highlights
- 전화번호 조회 로직 변경: 알림톡 전송을 위한 전화번호 조회 시, 기존 ProfileJpaRepository 대신 UserJpaRepository를 사용하여 사용자 정보를 직접 조회하도록 변경되었습니다.
- UserJpaEntity에 전화번호 형식화 메서드 추가: UserJpaEntity에 하이픈이 제거된 전화번호를 반환하는 getPhoneNumberWithoutHyphen() 메서드가 추가되어, 알림톡 전송 시 필요한 형식으로 전화번호를 쉽게 얻을 수 있게 되었습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
|
||
| private String retrievePhoneNumberByUserId(Long userId) { | ||
| return profileJpaRepository.findByUserId(userId) | ||
| return userJpaRepository.findById(userId) |
There was a problem hiding this comment.
이 줄에서 userJpaRepository를 사용하도록 변경되었으므로, 관련 로직도 함께 수정되어야 합니다. 유저를 찾지 못했을 경우, 다음 줄에서 ErrorCode.PROFILE_NOT_FOUND 예외가 발생하는데, 이는 혼란을 줄 수 있습니다. ErrorCode.USER_NOT_FOUND를 사용하도록 수정하는 것이 좋습니다.
제안:
다음 줄의 .orElseThrow(...) 부분을 아래와 같이 수정해주세요.
.orElseThrow(() -> new CustomRuntimeException(ErrorCode.USER_NOT_FOUND))1 participant
…umber formatting method
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타